[Petal] Petal and HTML Tidy
William McKee
william@knowmad.com
Thu, 8 Aug 2002 12:26:36 -0400
--Message-Boundary-11948
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Mail message body
On 8 Aug 2002 at 12:08, Jean-Michel Hiver wrote:
> You got it the wrong way around haven't you? :-) Effectively it's
> screwed up, but that's the template's fault, not tidy's.
Yes, I do. So, you're saying that embedding xml tags inside of html
attributes is illegal? I can see where that would be the fault of the
Petal template. Kinda loses the appeal of using Petal though if we can't
create valid html with it. If tidy is messing up these tags, wouldn't a
GUI html editor do the same? I suppose you're going to say to use the $tag
format <g>.
> Anyway, the new string: modifier should be your friend.
Although I'm against having the simple syntax or variable interpolation
embedded directly into templates, I can see where having these values
inside of attribute tags is ok. It's what you are calling the usual
syntax, which is essentially a valid xml tag I believe, which is causing
tidy to think this is invalid html and try to clean it up.
>
>
> Try:
Ok, so I tried using the variable interpolation inside of these attribute
properties. Still no joy. Tidy is turning:
<a href="string:$scriptname?rm=edit_coach&coach_id=$coach.coach_id">
into:
<a href="string:$scriptname?rm=edit_coach&coach_id=$coach.coach_id">
Notice the & is replaced by & in the tidied version. I haven't tested
this with Petal yet so it may not be correct Petal syntax, but I just want
to clear up issues with tidying these templates first. This seems like a
problem with tidy. Or is it? Perhaps that's a valid URL. Any HTTP experts
out there? My tests seem to indicate it is an acceptable format for the
browsers, but is it a valid URL?
BTW, Tidy does not mess with <?petal:var name="foo"?> tags that are on
their own. From what I've seen, it just reformats them if they are in an
attribute property.
> If it does not work, tell me, because I'd see it as a bug.
Ok, I've done some testing in Petal and there's some bugs in the string
modifier. I've attached a test.cgi and template for you to see for
yourself.
NB: I had to force Petal to use the HTML parser. I was getting an error if
I did not set this value in the test.cgi script. Try commenting out that
line and see if you get an error. It may be due to my messing with adding
support for instantiation variables. I'm still using a hacked copy of
Petal.pm. Looking forward to 0.6!
Thanks,
William
--
Lead Developer
Knowmad Services Inc. || Internet Applications & Database Integration
http://www.knowmad.com
--Message-Boundary-11948
Content-type: text/plain; charset=US-ASCII
Content-transfer-encoding: 7BIT
Content-description: Text from file 'test.cgi'
#!/usr/bin/perl
#
use strict;
use Petal;
use CGI::Carp qw/fatalsToBrowser/;
my $template_file = 'test.tmpl';
$Petal::DISK_CACHE = 0;
$Petal::MEMORY_CACHE = 0;
$Petal::TAINT = 1;
$Petal::BASE_DIR = './';
$Petal::PARSER = "HTML";
my $template = new Petal ($template_file);
my $hash = {
error_message => "Kilroy was Here",
first_name => "William",
last_name => "McKee",
email => 'william@knowmad.com',
students => [ { student_id => '1',
first_name => 'William',
last_name => 'McKee',
email => 'william@knowmad.com',
},
{ student_id => '2',
first_name => 'Elizabeth',
last_name => 'McKee',
email => 'elizabeth@knowmad.com',
},
],
};
my $html = $template->process($hash);
print "Content-type: text/html\n\n";
print $html;
--Message-Boundary-11948
Content-type: text/plain; charset=US-ASCII
Content-disposition: inline
Content-description: Attachment information.
The following section of this message contains a file attachment
prepared for transmission using the Internet MIME message format.
If you are using Pegasus Mail, or any another MIME-compliant system,
you should be able to save it or view it from within your mailer.
If you cannot, please ask your system administrator for assistance.
---- File information -----------
File: test.tmpl
Date: 8 Aug 2002, 12:21
Size: 3983 bytes.
Type: Unknown
--Message-Boundary-11948
Content-type: Application/Octet-stream; name="test.tmpl"; type=Unknown
Content-disposition: attachment; filename="test.tmpl"
Content-transfer-encoding: BASE64
PD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iaXNvLTg4NTktMSI/Pg0KPCEtLT8NCiMg
ICAgIFRlbXBsYXRlOiB0ZXN0LnRtcGwNCiMgICAgICBDcmVhdGVkOiAwNy0yMy0yMDAyDQoj
ICAgICBNb2RpZmllZDogMDctMjQtMjAwMg0KIyAgICAgICBBdXRob3I6IHdsbQ0KIyAgRGVz
Y3JpcHRpb246IFRlbXBsYXRlIHRvIGRvIHRlcnJpYmxlIHRoaW5ncyB0byB0ZXN0IFBldGFs
IHRlbXBsYXRlIGxhbmd1YWdlLg0KLS0+DQo8IURPQ1RZUEUgaHRtbCBQVUJMSUMgIi0vL1cz
Qy8vRFREIFhIVE1MIDEuMCBUcmFuc2l0aW9uYWwvL0VOIg0KICAgICJodHRwOi8vd3d3Lncz
Lm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS10cmFuc2l0aW9uYWwuZHRkIj4NCg0KPGh0bWwg
eG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzE5OTkveGh0bWwiPg0KICA8aGVhZD4NCiAgICA8
bWV0YSBuYW1lPSJnZW5lcmF0b3IiIGNvbnRlbnQ9IkhUTUwgVGlkeSBmb3IgV2luZG93cyAo
dmVycyAxc3QgSmFudWFyeSAyMDAyKSwgc2VlIHd3dy53My5vcmciIC8+DQoNCiAgICA8dGl0
bGU+UGV0YWwgU3RyZXNzIFRlc3QgVGVtcGxhdGU8L3RpdGxlPg0KICA8L2hlYWQ+DQogIDwh
LS0/IDw/cGV0YWw6aW5jbHVkZSBmaWxlPSJpbmNsdWRlcy9oZWFkZXIudG1wbCI/PiAtLT4N
Cg0KICA8Ym9keT4NCiAgICA8aDM+VGhlIHRhZ3M6PC9oMz4NCg0KICAgIDx1bD4NCiAgICAg
IDxsaT5lcnJvcl9tZXNzYWdlOiA8c3BhbiBwZXRhbDpjb250ZW50PSJlcnJvcl9tZXNzYWdl
Ij5FcnJvcjwvc3Bhbj48L2xpPg0KDQogICAgICA8bGk+Zmlyc3RfbmFtZTogPHNwYW4gcGV0
YWw6Y29udGVudD0iZmlyc3RfbmFtZSI+Rmlyc3Q8L3NwYW4+PC9saT4NCg0KICAgICAgPGxp
Pmxhc3RfbmFtZTogPHNwYW4gcGV0YWw6Y29udGVudD0ibGFzdF9uYW1lIj5MYXN0PC9zcGFu
PjwvbGk+DQoNCiAgICAgIDxsaT5lbWFpbDogPHNwYW4gcGV0YWw6Y29udGVudD0iZW1haWwi
PkVtYWlsPC9zcGFuPjwvbGk+DQoNCiAgICAgIDxsaT4NCiAgICAgICAgU3R1ZGVudHMgTGlz
dDxiciAvPg0KICAgICAgICAgDQoNCiAgICAgICAgPHVsIHBldGFsOnJlcGVhdD0ic3R1ZGVu
dCBzdHVkZW50cyI+DQogICAgICAgICAgPGxpPjw/cGV0YWw6dmFyIG5hbWU9ImVuY29kZTog
c3R1ZGVudC5maXJzdF9uYW1lIj8+DQogICAgICAgICAgPD9wZXRhbDp2YXIgbmFtZT0iZW5j
b2RlOiBzdHVkZW50Lmxhc3RfbmFtZSI/Pg0KICAgICAgICAgIC0gPD9wZXRhbDp2YXIgbmFt
ZT0iZW5jb2RlOiBzdHVkZW50LmVtYWlsIj8+DQogICAgICAgICAgPC9saT4NCiAgICAgICAg
PC91bD4NCiAgICAgIDwvbGk+DQogICAgPC91bD4NCiAgICA8aHIgc2l6ZT0iOSIgd2lkdGg9
Ijk1JSIgLz4NCg0KICAgIDxoMz5UaGUgTm9uLVdvcmtpbmcgVGVzdHM8L2gzPg0KDQogICAg
PHA+U3RyaW5nIG1vZGlmaWVyIGVycm9yPC9wPg0KDQogICAgPHA+PGEgcGV0YWw6YXR0cj0i
aHJlZiBzdHJpbmc6dGVzdC5jZ2k/cm09ZWRpdF9jb2FjaCZhbXA7Zm49JGZpcnN0X25hbWUi
Pjw/cGV0YWw6dmFyIG5hbWU9ImVuY29kZTogZmlyc3RfbmFtZSI/Pg0KICAgICA8P3BldGFs
OnZhciBuYW1lPSJlbmNvZGU6IGxhc3RfbmFtZSI/Pg0KICAgIDwvYT48L3A+DQoNCiAgICA8
cD48YSBwZXRhbDphdHRyPSJocmVmIHN0cmluZzptYWlsdG8vOiRlbWFpbCI+PHNwYW4gcGV0
YWw6Y29udGVudD0iZW5jb2RlOiBlbWFpbCI+RW1haWw8L3NwYW4+PC9hPjwvcD4NCiAgICA8
IS0tPw0KICAgIDxwPiZuYnNwOzwvcD4NCiAgICA8aHIgc2l6ZT0iOSIgd2lkdGg9Ijk1JSI+
DQoNCiAgICA8aDM+VGhlIFdvcmtpbmcgVGVzdHM8L2gzPg0KDQogICAgPHA+U3RhY2tlZCBw
ZXRhbCB0YWdzPC9wPg0KICAgIDxwIGNsYXNzPSJlcnJvciIgcGV0YWw6aWY9ImVycm9yX21l
c3NhZ2UiIHBldGFsOmNvbnRlbnQ9ImVycm9yX21lc3NhZ2UiPkVycm9yPC9wPg0KDQogICAg
PGhyIHNpemU9IjUiIHdpZHRoPSI3NSUiPg0KDQogICAgPHA+MS4gQSB0YWcgd2l0aGluIGFu
IGh0bWwgdGFnIHByb3BlcnR5IGRvZXNuJ3Qgd29yaywgaW4gc29tZSBjYXNlcy4gV29ya3Mg
aWYgdGhlcmUgaXMgbm8gaW5jbHVkZSB0YWcgYWJvdmUgaXQuIERvZXMgbm90IHdvcmsgaWYg
dGhlcmUgaXMgYW4gaW5jbHVkZSB0YWcgYWJvdmUgaXQuDQogICAgPGJyIC8+DQogICAgPGEg
aHJlZj0ibWFpbHRvOjw/cGV0YWw6dmFyIG5hbWU9ImVtYWlsIj8+Ij5FbWFpbDwvYT4NCiAg
ICA8L3A+DQoNCiAgICA8aHIgc2l6ZT0iNSIgd2lkdGg9Ijc1JSI+DQoNCiAgICA8cD4yLiBU
d28gdGFncyBpbiBhIHJvdyB3aWxsIG9ubHkgc2hvdyB0aGUgZmlyc3QsIG9yIG5vdGhpbmcg
YXQgYWxsLiBJJ20gbm90IHN1cmUgd2h5IHRoaXMgZm9ybWF0IGlzbid0IHdvcmtpbmcgYXQg
YWxsIGluIHRoaXMgdGVzdCB0ZW1wbGF0ZS4gSXQgZG9lcyB3b3JrIGluIGFub3RoZXIgb2Yg
bXkgdGVtcGxhdGVzLiBQZXJoYXBzIGl0IGlzIGR1ZSB0byB0aGUgZXJyb3IgaW4gdGhlIGFi
b3ZlIHRhZy4gQ29tbWVudGluZyBvdXQgdGhlIGFib3ZlIHRhZyBkb2Vzbid0IHNlZW0gdG8g
bWFrZSBhbnkgZGlmZmVyZW5jZSwgdGhvdWdoLiBEbyB0YWdzIGluc2lkZSBvZiBjb21tZW50
cyBnZXQgZXhlY3V0ZWQ/DQogICAgPGJyIC8+DQogICAgPD9wZXRhbDp2YXIgbmFtZT0iZW5j
b2RlOiBmaXJzdF9uYW1lIj8+IDxiciAvPg0KICAgIDw/cGV0YWw6dmFyIG5hbWU9ImVuY29k
ZTogZmlyc3RfbmFtZSI/PiA8P3BldGFsOnZhciBuYW1lPSJlbmNvZGU6IGxhc3RfbmFtZSI/
Pg0KICAgIDwvcD4NCg0KICAgIDxociBzaXplPSI1IiB3aWR0aD0iNzUlIj4NCg0KICAgIDxw
PjMuIEluY2x1ZGVzIGRvbid0IGFsd2F5cyB3b3JrLiBUcnkgbW92aW5nIG9uZSBvZiB0aGUg
dGFncyB0byB0aGUgdG9wIGFuZCBzZWUgdGhlIHJlc3VsdHMuIFJhdGhlciBjdXJpb3VzLi4u
IElmIHlvdSBtb3ZlIHRoZSBmb290ZXIgdG8gdGhlIHRvcCwgeW91J2xsIHNlZSB0aGF0IGl0
IGdldHMgc2hvd24gdHdpY2UgaWYgeW91IGhhdmUgMiBmb290ZXIgaW5jbHVkZXMgc3RhdGVt
ZW50cyBmb2xsb3dpbmcgaXQ7IGlmIHlvdSByZW1vdmUgdGhlIGxhc3Qgb25lIGp1c3QgYWJv
dmUgdGhlIC9ib2R5IHRhZywgeW91J2xsIHNlZSB0aGUgb25lIGFmdGVyIGhlYWRlciBpc24n
dCB3b3JraW5nLCBidXQgZnVydGhlciBvbmVzIGRvLiBUaGVyZSBpcyBhcHBhcmVudGx5IHNv
bWV0aGluZyBpbiB0aGUgaGVhZGVyLnRtcGwgZG9jdW1lbnQgd2hpY2ggaXMgY2F1c2luZyBQ
ZXRhbCB0byBub3QgcGVyZm9ybSB0aGUgbmV4dCBpbmNsdWRlcy4gSW4gZmFjdCwgeW91IGNh
biBrZWVwIGFkZGluZyBmb290ZXIgaW5jbHVkZXMgYW5kIGdldCBtb3JlIGFuZCBtb3JlIHJl
c3VsdHMgYXMgZXhwZWN0ZWQuDQogICAgPGJyIC8+DQogICAgPD9wZXRhbDppbmNsdWRlIGZp
bGU9ImluY2x1ZGVzL2hlYWRlci50bXBsIj8+DQogICAgPHA+VGhpcyBpbmNsdWRlIHdvbid0
IGdldCBkaXNwbGF5ZWQ8L3A+DQogICAgPD9wZXRhbDppbmNsdWRlIGZpbGU9ImluY2x1ZGVz
L2Zvb3Rlci50bXBsIj8+DQoNCiAgICA8aHIgc2l6ZT0iNSIgd2lkdGg9Ijc1JSI+DQoNCiAg
ICA8cD5DcmVhdGluZyBhIGxpbms8L3A+DQogICAgICAgIDx1bCBwZXRhbDpyZXBlYXQ9InN0
dWRlbnQgc3R1ZGVudHMiPg0KICAgICAgICAgICAgPGxpPjxhIGhyZWY9IiI+PD9wZXRhbDp2
YXIgbmFtZT0iZW5jb2RlOiBzdHVkZW50LmZpcnN0X25hbWUiPz4gPD9wZXRhbDp2YXIgbmFt
ZT0iZW5jb2RlOiBzdHVkZW50Lmxhc3RfbmFtZSI/PiAtIDw/cGV0YWw6dmFyIG5hbWU9ImVu
Y29kZTogc3R1ZGVudC5lbWFpbCI/PjwvYT48L2xpPg0KICAgICAgICA8L3VsPg0KDQogICAg
PGhyIHNpemU9IjUiIHdpZHRoPSI3NSUiPg0KDQogICAgPGgzPkVuZCBUZXN0czwvaDM+DQoN
CiAgICA8P3BldGFsOmluY2x1ZGUgZmlsZT0iaW5jbHVkZXMvZm9vdGVyLnRtcGwiIHRhaW50
PSIxIj8+DQoNCiAgICAtLT4NCiAgPC9ib2R5Pg0KPC9odG1sPg0KDQo=
--Message-Boundary-11948--